Skip to content

fix: keep full soup food on every scoop - #33

Merged
Drefvelin merged 1 commit into
mainfrom
fix/soup-scoop-food
Sep 23, 2026
Merged

fix: keep full soup food on every scoop#33
Drefvelin merged 1 commit into
mainfrom
fix/soup-scoop-food

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Ladling soup no longer divides the dish's food by pot-soup-scoops. Each bowl keeps the soup template food (26), and nutrition stays at the template level.
  • The pot still yields the configured number of scoops and still lowers the liquid display as bowls are taken.

Documentation impact

  • Central Cooking documentation: no change
  • Contract docs do not describe soup food as split across scoops.

Contract

  • Affected behavior: a soup scoop's food is the soup type's food value. Serving count still limits how many bowls one pot gives and how the liquid level drops.
  • Tests run (mvn test, or why not): mvn -Dtest=PortionRulesTest,ValuableIngredientTest test
  • Player wiki (ProvinceSystem /wiki/cooking or related pages): no change

Notes

  • Config source is src/main/resources. Do not edit target/.
  • plugin.yml version and pom.xml version are known drift. Do not mix a version bump into unrelated work.
  • cookware.yml is not loaded.

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Soup scoops now retain the recipe’s full base food value instead of receiving a value reduced by the number of scoops. Nutrition values remain unchanged. This corrects the food amount shown for each scoop and keeps it consistent with the recipe’s template value.

@Drefvelin @cursoragent
fix: keep full soup food on every scoop
907e6a9 
Ladling a pot was splitting the soup template food by the serving count, so each bowl was only a fraction of the dish.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1e987e66-26a5-4e48-81f8-16ee42ebb6ac

📥 Commits

Reviewing files that changed from the base of the PR and between 5f9b959 and 907e6a9.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/cooking/cooking/PotReference.java
  • src/test/java/net/tfminecraft/cooking/item/PortionRulesTest.java
  • src/test/java/net/tfminecraft/cooking/item/ValuableIngredientTest.java
💤 Files with no reviewable changes (1)
  • src/test/java/net/tfminecraft/cooking/item/ValuableIngredientTest.java

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Soup scooping now uses the template food value unchanged. The scoopFood method no longer takes a scoop count. Tests now check the updated method signature and food value.

Changes

Soup scoop food value

Layer / File(s) Summary
Update soup food value handling
src/main/java/net/tfminecraft/cooking/cooking/PotReference.java, src/test/java/net/tfminecraft/cooking/item/PortionRulesTest.java, src/test/java/net/tfminecraft/cooking/item/ValuableIngredientTest.java		 scoopFood now accepts one argument and returns the template food value unchanged. The soup result call and updated test use the new signature. The test for dividing food by scoop count and its unused imports are removed.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to 907e6

Each soup serving retains the template food value through consumption, subject to the usual quality and nutrition modifiers. No material merge risk was identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description includes all required sections. It clearly explains the soup serving behavior, documentation impact, affected behavior, targeted tests, wiki impact, and repository notes.
Title check ✅ Passed The title clearly and concisely describes the primary change: each soup scoop keeps the full food value.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 775bd6c into main Sep 23, 2026
2 checks passed
@Drefvelin
Drefvelin deleted the fix/soup-scoop-food branch September 23, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Drefvelin